Skip to content

test: raise default poll_until_condition timeout to deflake integration tests#868

Open
vdusek wants to merge 1 commit into
masterfrom
test/deflake-integration-poll-timeout
Open

test: raise default poll_until_condition timeout to deflake integration tests#868
vdusek wants to merge 1 commit into
masterfrom
test/deflake-integration-poll-timeout

Conversation

@vdusek

@vdusek vdusek commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The test_request_queue_list_and_lock_head integration test flaked on a loaded Python 3.14 CI runner: after adding 5 requests, the queue head stayed empty past the 5s poll ceiling (assert 0 == 5). The Apify platform's listing endpoints are eventually consistent, so the 5s default in poll_until_condition was too tight under parallel load.

Raise the default timeout from 5s to 30s, and drop the now-redundant explicit timeout=30 overrides in the request-queue and run tests. The timeout is only a ceiling, so happy paths are unaffected.

Failing CI run: https://github.com/apify/apify-client-python/actions/runs/27765226958/job/82149997276

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 18, 2026
@vdusek vdusek self-assigned this Jun 18, 2026
@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 18, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (2895adb) to head (068acd6).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #868       +/-   ##
===========================================
+ Coverage   83.26%   94.47%   +11.21%     
===========================================
  Files          48       48               
  Lines        5072     5072               
===========================================
+ Hits         4223     4792      +569     
+ Misses        849      280      -569     
Flag Coverage Δ
integration 92.58% <ø> (?)
unit 83.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from Pijukatel June 18, 2026 14:37
@vdusek vdusek marked this pull request as ready for review June 18, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants